Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ is broken #6608

Closed
ellisonbg opened this issue Jun 18, 2019 · 6 comments · Fixed by #6628
Closed

FAQ is broken #6608

ellisonbg opened this issue Jun 18, 2019 · 6 comments · Fixed by #6628

Comments

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 18, 2019

In the help menu, we have an FAQ option. It is currently broken. This raises a bigger question though about what we should do with it. Should we update it? Remove it?

@ellisonbg ellisonbg added this to the 1.0 milestone Jun 18, 2019
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 18, 2019

This may be a consequence of switching to ES6 imports. I can take a look this evening. I think it makes sens to still have to FAQ, with some light updating.

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Jun 18, 2019

In discussion, we decided to:

  • Remove the FAQ extension.
  • Add a "JupyterLab FAQ" help link that points to the JupyterLab main FAQ in the docs.

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 18, 2019

In discussion, we decided to:

To be fair, that discussion did not include @ian-r-rose's thoughts about why we should still have a FAQ.

To me, it's redundant with the docs, so not needed. We can have a menu item that opens up the doc page.

Why do you think it is still needed, @ian-r-rose?

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jun 19, 2019

ping @ian-r-rose for more information about why we should keep this. What are you thoughts about it?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 19, 2019

Ah, I thought I had commented, must not have pressed send.

I don't have strong feelings about it, except that the Q's in the FAQ really are FA'd, so it seemed reasonable to keep it in for a while. Not everyone is an early adopter, so for a lot of people this may be the first time seeing Lab. But if that information is available elsewhere, I think we can remove it.

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants