Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of linked packages #6738

Closed
blink1073 opened this issue Jun 29, 2019 · 2 comments · Fixed by #7728
Closed

Better handling of linked packages #6738

blink1073 opened this issue Jun 29, 2019 · 2 comments · Fixed by #7728
Assignees
Labels
bug status:resolved-locked tag:Build System
Milestone

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 29, 2019

@SylvainCorlay reported this while working on the ipywidgets upgrade. I'm going to come up with a repro, but the general idea is:

  • make an extension that depends on a published library

  • check out that library locally

  • bump the version number

  • run jupyter labextension link

  • change directories back to the extension

  • run jupyter labextension link

At this point, jupyter lab complains that it cannot find a published version of the linked dependency.

@vidartf
Copy link
Member

@vidartf vidartf commented Jun 29, 2019

Does it matter if the extension in question has an npm/yarn link to the library set up?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 29, 2019

We tried that, it didn't work

@blink1073 blink1073 removed this from the 1.1 milestone Aug 27, 2019
@blink1073 blink1073 added this to the 1.2 milestone Aug 27, 2019
@jasongrout jasongrout removed this from the 1.2 milestone Oct 11, 2019
@jasongrout jasongrout added this to the 2.0 milestone Oct 11, 2019
@blink1073 blink1073 removed this from the 2.0 milestone Dec 23, 2019
@blink1073 blink1073 added this to the 3.0 milestone Dec 23, 2019
@blink1073 blink1073 removed this from the 3.0 milestone Jan 3, 2020
@blink1073 blink1073 added this to the 2.0 milestone Jan 3, 2020
@lock lock bot added the status:resolved-locked label Feb 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked tag:Build System
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants