Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Renders for Cell Type Output Type Error #7193

Closed
mlucool opened this issue Sep 11, 2019 · 0 comments · Fixed by #7203
Closed

Custom Renders for Cell Type Output Type Error #7193

mlucool opened this issue Sep 11, 2019 · 0 comments · Fixed by #7203

Comments

@mlucool
Copy link
Contributor

@mlucool mlucool commented Sep 11, 2019

Hi,

I'd like to add a skip-traceback extension to lab (ipython-contrib/jupyter_contrib_nbextensions#1445). The current model make this hard to do reliably, so I wanted to flesh out a design change here before making a pull request.

OutputModel getData conflates errors with stderr stream, although nbformat treats these as a unique type. I'd like to:

  1. Add in a mimetype for error ("failed execution"): application/vnd.jupyter.error
  2. Pass all nbformat data to this bundle (i.e. traceback, ename, evalue)
  3. Create a mime render which defaults to treating this error as application/vnd.jupyter.stderr. Alternatively, we can add an extra mimetype to the bundle and it should continue to work as it without changes.

After this is done, others will be able to create a mimerender for application/vnd.jupyter.error to create a skip-traceback or similar extensions.

What do you think?

mlucool pushed a commit to mlucool/jupyterlab that referenced this issue Sep 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant