Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing metadata from kernelspec model #7228

Closed
declanvk opened this issue Sep 18, 2019 · 1 comment · Fixed by #7229
Closed

Missing metadata from kernelspec model #7228

declanvk opened this issue Sep 18, 2019 · 1 comment · Fixed by #7229
Labels
pkg:services status:resolved-locked

Comments

@declanvk
Copy link
Contributor

@declanvk declanvk commented Sep 18, 2019

Hello,

Currently the documentation and the /api/kernelspecs endpoint have a field for metadata included in a kernelspec. However, that field is not included in the ISpecModel.

I also noticed that while the env field exists on the ISpecModel, the validation code in validate.ts does not check if the env is present on the incoming message and never adds it to the model.

I propose to add metadata to ISpecModel + validation code, and env to the validation code.

@dleen @blink1073

@declanvk
Copy link
Contributor Author

@declanvk declanvk commented Sep 18, 2019

@meeseeksdev "pkg:services"

@lock lock bot added the status:resolved-locked label Oct 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:services status:resolved-locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants