Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent versioning of React and related packages #7655

Closed
telamonian opened this issue Dec 18, 2019 · 0 comments · Fixed by #7661
Closed

inconsistent versioning of React and related packages #7655

telamonian opened this issue Dec 18, 2019 · 0 comments · Fixed by #7661
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@telamonian
Copy link
Member

telamonian commented Dec 18, 2019

Description

Currently, our handling of React versioning is a little... weird. Here's how we're currently versioning react, react-dom, and the related @types packages in core:

"react": "~16.12.0",
"react-dom": "~16.12.0",
"@types/react": "~16.9.16",   
"@types/react-dom": "^16.9.4",

Though guidance is a little thin, so far as I can tell the best practice would be for the minor version of all these packages to match. There's no newer versions of the @types packages yet, so I propose that we roll back react/react-dom to 16.9.x. Also, we should probably use a ~ for the version range of react-dom, instead of ^

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant