Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Settings does not trigger application dirty state #7757

Closed
jasongrout opened this issue Jan 8, 2020 · 1 comment · Fixed by #7774
Closed

Advanced Settings does not trigger application dirty state #7757

jasongrout opened this issue Jan 8, 2020 · 1 comment · Fixed by #7774
Labels
status:resolved-locked tag:Settings

Comments

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 8, 2020

If you are editing settings, then accidentally refresh, the application refreshes without prompting you to save the setting text. Instead, we should have the advanced setting editor trigger the application dirty status when it has unsaved content.

@Madhu94
Copy link
Collaborator

@Madhu94 Madhu94 commented Jan 11, 2020

I'll take a look at this.

Madhu94 added a commit to Madhu94/jupyterlab that referenced this issue Jan 12, 2020
@lock lock bot added the status:resolved-locked label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Settings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants