Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom session startup behavior for widgets #7996

Closed
blink1073 opened this issue Mar 5, 2020 · 3 comments · Fixed by #8066
Closed

Allow custom session startup behavior for widgets #7996

blink1073 opened this issue Mar 5, 2020 · 3 comments · Fixed by #8066
Assignees
Labels
pkg:docregistry pkg:notebook status:resolved-locked
Milestone

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 5, 2020

We currently offer some declarative kernel preferences on the widget factories that are used to define the behavior of kernel startup. I propose that we add an option to provide a callback function, so that the widget factory has full control over the startup behavior, and can take into account external factors such as the result of an API call or information in the document itself.

Additionally, we should expose the NotebookWidgetFactory as a token and a separate plugin, so it is easier to override this behavior for notebooks.

@blink1073 blink1073 added this to the 2.1 milestone Mar 5, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 5, 2020

Makes sense to me.

@jasongrout jasongrout modified the milestones: 2.1, 3.0 Mar 12, 2020
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 20, 2020

I'd like to implement just the ability to override the NotebookWidgetFactory in 2.1 and save the more invasive changes for 3.0.

@blink1073 blink1073 modified the milestones: 3.0, 2.1 Mar 20, 2020
@blink1073 blink1073 self-assigned this Mar 20, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 20, 2020

I'd like to implement just the ability to override the NotebookWidgetFactory in 2.1 and save the more invasive changes for 3.0.

Sounds good to me.

@lock lock bot added the status:resolved-locked label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:docregistry pkg:notebook status:resolved-locked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants