Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot replace with an empty text #8098

Closed
krassowski opened this issue Mar 27, 2020 · 2 comments · Fixed by #8100
Closed

Cannot replace with an empty text #8098

krassowski opened this issue Mar 27, 2020 · 2 comments · Fixed by #8100
Labels
bug pkg:documentsearch status:resolved-locked tag:Search and Replace
Milestone

Comments

@krassowski
Copy link
Member

@krassowski krassowski commented Mar 27, 2020

Description

Replacing text with an empty string is not possible.

replace_does_not_work_if_empty

Reproduce

  1. Open search bar
  2. Enter some text which exists in the document
  3. Open the replace bar, do not enter anything in the replace input
  4. Press the "Replace" button
  5. See that nothing happens

Expected behavior

The selected (found) match should be removed. This is how it works in Gedit, Pycharm and most other editors that I have used so far. Gedit example:

works_in_gedit

Context

  • Operating System and version: Ubuntu 19.10
  • Browser and version: Chrome 80.0.3987.149
  • JupyterLab version: Version 2.0.1
@krassowski
Copy link
Member Author

@krassowski krassowski commented Mar 27, 2020

Also, the buttons do not have pressed (:active) state (as you can see on the gif it is hard to tell that I pressed the replace button many times) - should I open a bug report for that, or is this a design decision?

jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Mar 27, 2020
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Mar 27, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 27, 2020

Thanks! Fixed in #8100

@jasongrout jasongrout added this to the 2.1 milestone Mar 27, 2020
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:documentsearch status:resolved-locked tag:Search and Replace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants