Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jp-CodeMirrorEditor-staticHTML element class #8537

Closed
AlbertHilb opened this issue Jun 9, 2020 · 1 comment · Fixed by #8547
Closed

jp-CodeMirrorEditor-staticHTML element class #8537

AlbertHilb opened this issue Jun 9, 2020 · 1 comment · Fixed by #8547
Labels
pkg:codemirror question status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes

Comments

@AlbertHilb
Copy link
Member

AlbertHilb commented Jun 9, 2020

In the base.css stylesheet from the codemirror package, there are two rules associated to the class selector .jp-CodeMirrorEditor-static, but I can't find any other occurence of the string jp-CodeMirrorEditor-static into the entire jupyterlab source tree, so I assume HTML elements with such a class can not exist. Can those rules be safely removed?

@AlbertHilb AlbertHilb added question pkg:codemirror tag:CSS For general CSS related issues and pecadilloes labels Jun 9, 2020
@blink1073
Copy link
Member

blink1073 commented Jun 11, 2020

I'd say yes, they can be removed.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:codemirror question status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants