Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ToC icon usage to LabIcon #8557

Closed
marthacryan opened this issue Jun 12, 2020 · 2 comments · Fixed by #8692
Closed

Update ToC icon usage to LabIcon #8557

marthacryan opened this issue Jun 12, 2020 · 2 comments · Fixed by #8692
Assignees
@marthacryan
Labels
good first issue pkg:toc pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@marthacryan
Copy link
Member

marthacryan commented Jun 12, 2020 •
edited

Currently the ToC package uses icons located in packages/toc/style/img, but these icons should be moved to ui-components and imported to ToC using LabIcon. Referenced in #8546.
@marthacryan
Copy link
Member Author

@ajbozarth Has volunteered to help out with this.

@ajbozarth ajbozarth self-assigned this Jun 12, 2020
@ajbozarth ajbozarth removed their assignment Jun 23, 2020
@ajbozarth
Copy link
Contributor

Unassigned myself for now. I don't have the bandwidth for this at the moment and this is a good first issue for others to learn more about LabIcon

@marthacryan marthacryan self-assigned this Jul 14, 2020
@marthacryan marthacryan mentioned this issue Jul 16, 2020
Merged
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marthacryan marthacryan

Labels
good first issue pkg:toc pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change toc to use labicon marthacryan/jupyterlab
2 participants
@marthacryan @ajbozarth