Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch handling for non-symlinked dynamic extensions #8869

Closed
blink1073 opened this issue Aug 20, 2020 · 0 comments · Fixed by #8950
Closed

Add watch handling for non-symlinked dynamic extensions #8869

blink1073 opened this issue Aug 20, 2020 · 0 comments · Fixed by #8950
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Extensions
Milestone

Comments

@blink1073
Copy link
Member

Problem

Extensions that are installed with labextension develop without a symlink currently do not support watch mode.

Proposed Solution

  • When we call labextension watch, check for a symlink to the watched directory. If none exists, check for a labextensions directory. If none exists, bail. If there is a labextensions directory, set up file system watchers to copy changes to that location from the src directory of the extension in addition to running the local watch command.
@blink1073 blink1073 added this to the 3.0 milestone Aug 20, 2020
@blink1073 blink1073 added this to To do in Extension System rework via automation Aug 20, 2020
Extension System rework automation moved this from To do to Done Sep 3, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Extensions
Projects
Development

Successfully merging a pull request may close this issue.

1 participant