Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using webpack 5 auto public path #9043

Closed
jasongrout opened this issue Sep 19, 2020 · 0 comments · Fixed by #9062
Closed

Investigate using webpack 5 auto public path #9043

jasongrout opened this issue Sep 19, 2020 · 0 comments · Fixed by #9062
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Sep 19, 2020

Right now, we have a solution for setting the public path in a compiled extension that involves writing some modules at compile time, etc. It works, but it's a bit of a hack, both in the writing of the modules and in how they are included in the module federation bundle.

In webpack/webpack#11258 (webpack 5.0b32), and interesting "auto" option is introduced. We may be able to use it.

@jasongrout jasongrout added this to the 3.1 milestone Sep 19, 2020
@jasongrout jasongrout changed the title Webpack 5.0b32 has auto public path that we might use Investigate using webpack 5 auto public path Sep 19, 2020
@jasongrout jasongrout modified the milestones: 3.1, 3.0 Sep 19, 2020
@jasongrout jasongrout added this to To do in Extension System rework via automation Sep 19, 2020
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Sep 23, 2020
This removes a hardcoded assumption about where the lab extensions live in the server url namespace, making things more flexible for the future.

Fixes jupyterlab#9043
Extension System rework automation moved this from To do to Done Sep 24, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant