Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for watch mode in 3.0 #9089

Closed
jtpio opened this issue Sep 28, 2020 · 1 comment · Fixed by #9101
Closed

Support for watch mode in 3.0 #9089

jtpio opened this issue Sep 28, 2020 · 1 comment · Fixed by #9101
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 28, 2020

Running in a new environment with the latest JupyterLab 3.0.0rc1, it looks like the watch mode is making the server hangs on startup.

To reproduce:

  • create a new environment
  • python -m pip install --pre jupyterlab
  • jupyter lab --no-browser --watch

This results in the LapApp not logging the server url:

Entrypoint main 406 KiB = vendors-node_modules_whatwg-fetch_fetch_js.f6327745ab1376187dec.js 43.7 KiB main.2deb5ac19ce4adc2793f.js 363 KiB
orphan modules 210 KiB [orphan] 206 modules
runtime modules 140 KiB 14 modules
modules by path ./node_modules/ 13.1 MiB
  cacheable modules 13.1 MiB 998 modules
  3 modules
consume-shared-module modules 2.95 KiB
  modules by path consume shared module (default) @jupyterlab/ 1.93 KiB 47 modules
  modules by path consume shared module (default) @lumino/ 504 bytes 12 modules
  13 modules
provide-module modules 2.42 KiB
  modules by path provide shared module (default) @jupyterlab/ 1.85 KiB 45 modules
  modules by path provide shared module (default) @lumino/ 504 bytes 12 modules
  2 modules
modules by path ./build/ 19.2 KiB
  modules by path ./build/*.js 14.2 KiB 2 modules
  modules by path ./build/*.css 5.06 KiB 2 modules
modules by path  99 bytes 3 modules
./publicpath.js 1.38 KiB [built] [code generated]
webpack 5.0.0-rc.0 compiled successfully in 34155 ms

asset index.css 15.7 KiB [compared for emit] (name: index)
asset index.js 0 bytes [compared for emit] [minimized] (name: index)
Entrypoint index 15.7 KiB = index.css 15.7 KiB index.js 0 bytes
runtime modules 0 bytes 1 module
css modules 15.7 KiB
  css ./node_modules/css-loader/dist/cjs.js!./node_modules/@jupyterlab/theme-dark-extension/style/variables.css 15.3 KiB [built] [code generated]
  css ./node_modules/css-loader/dist/cjs.js!./node_modules/@jupyterlab/theme-dark-extension/style/index.css 472 bytes [built] [code generated]
./node_modules/@jupyterlab/theme-dark-extension/style/index.css 39 bytes [built] [code generated]
webpack 5.0.0-rc.0 compiled successfully in 12405 ms

asset index.css 14.7 KiB [compared for emit] (name: index)
asset index.js 0 bytes [compared for emit] [minimized] (name: index)
Entrypoint index 14.7 KiB = index.css 14.7 KiB index.js 0 bytes
runtime modules 0 bytes 1 module
css modules 14.7 KiB
  css ./node_modules/css-loader/dist/cjs.js!./node_modules/@jupyterlab/theme-light-extension/style/variables.css 14.2 KiB [built] [code generated]
  css ./node_modules/css-loader/dist/cjs.js!./node_modules/@jupyterlab/theme-light-extension/style/index.css 472 bytes [built] [code generated]
./node_modules/@jupyterlab/theme-light-extension/style/index.css 39 bytes [built] [code generated]
webpack 5.0.0-rc.0 compiled successfully in 12401 ms
@jtpio
Copy link
Member Author

jtpio commented Sep 28, 2020

We probably still want to support running lab with jupyter lab --watch for 3.0, since some extension authors might still want to keep their previous workflows or bundle their extensions.

@jasongrout jasongrout added this to the 3.0 milestone Sep 28, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants