Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch mode for non-federated third-party extensions #9116

Closed
jtpio opened this issue Sep 30, 2020 · 2 comments · Fixed by #9146
Closed

Watch mode for non-federated third-party extensions #9116

jtpio opened this issue Sep 30, 2020 · 2 comments · Fixed by #9146
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 30, 2020

Description

Follow-up to #9101 and #9089

Running jupyter lab --no-browser --watch doesn't seem to pick up changes when the extension is built.

Reproduce

Create a new environment and install lab with python -m pip install --pre jupyterlab.

Tested while updating the @jupyter-voila/jupyterlab-preview extension to support 3.0, but without switching to the new structure (yet): voila-dashboards/voila#732

The extension seems to be picked up and linked correctly though:

JupyterLab v3.0.0rc2
Other labextensions (built into JupyterLab)
   app dir: /path/to/miniconda/envs/voila/share/jupyter/lab
        @jupyter-voila/jupyterlab-preview v1.1.0 enabled OK*


   local extensions:
        @jupyter-voila/jupyterlab-preview: /path/to/git/voila/packages/jupyterlab-voila

Context

JupyterLab 3.0.0rc2

@jtpio
Copy link
Member Author

jtpio commented Sep 30, 2020

@jasongrout jasongrout added this to the 3.0 milestone Sep 30, 2020
@telamonian
Copy link
Member

telamonian commented Sep 30, 2020

The easy fix will be to just do a union regex. This will need some testing, but then I'll open a PR:

WEBPACK_EXPECT = re.compile(r'(?:.*/index.out.js)|(?:.*theme-light-extension/style/index.css)')

current:

WEBPACK_EXPECT = re.compile(r'.*theme-light-extension/style/index.css')

@afshin afshin mentioned this issue Oct 9, 2020
@afshin afshin closed this as completed Oct 9, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants