Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter labextension uninstall deletes federated extensions #9230

Closed
jasongrout opened this issue Oct 27, 2020 · 0 comments · Fixed by #9232
Closed

jupyter labextension uninstall deletes federated extensions #9230

jasongrout opened this issue Oct 27, 2020 · 0 comments · Fixed by #9232
Assignees
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

Description

jupyter labextension uninstall deletes federated extensions, but federated extensions should not be managed by jupyter labextension, since they are managed by other package managers.

Reproduce

conda create -y -n jlab-extension python nodejs
conda activate jlab-extension
pip install --pre jupyterlab
pip install --pre jupyterlab_widgets

This installs the new federated extension for ipywidgets. We can see it in

jupyter labextension list

We can uninstall it with

jupyter labextension uninstall @jupyter-widgets/jupyterlab-manager

Expected behavior

I expect jupyter labextension list to distinguish between federated and non-federated extensions, i.e., extensions installed by labextension and those that are not.

I expect jupyter labextension uninstall to not uninstall federated extensions, since it is not responsible for managing their files and cannot install them. Essentially, by uninstalling by removing the appropriate share directory, you are deleting files installed by a python package without uninstalling the python package, messing things up.

Context

  • Operating System and version: macOS Catalina
  • JupyterLab version: JLab 3.0rc6
@jasongrout jasongrout added this to the 3.0 milestone Oct 27, 2020
@jasongrout jasongrout added this to To do in Extension System rework via automation Oct 27, 2020
@jasongrout jasongrout moved this from To do to In progress in Extension System rework Oct 27, 2020
@jasongrout jasongrout self-assigned this Oct 28, 2020
Extension System rework automation moved this from In progress to Done Oct 30, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant