Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension manager should be as helpful as labextension for prebuilt extensions #9367

Closed
jasongrout opened this issue Nov 18, 2020 · 8 comments · Fixed by #9390
Closed

Extension manager should be as helpful as labextension for prebuilt extensions #9367

jasongrout opened this issue Nov 18, 2020 · 8 comments · Fixed by #9390
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

Currently, jupyter labextension uninstall and jupyter labextension list give extra information for packages with an install.json, namely listing the package manager and package name, and also the uninstall instructions.

The extension manager should give similar information for those just using the UX.

@jasongrout jasongrout added this to the 3.0 milestone Nov 18, 2020
@jasongrout
Copy link
Contributor Author

@echarles - is there some time, maybe tomorrow or early next week, that we could coordinate getting this done? We can divide the work so that I do the server side api and you do the extension manager ux, for example.

@echarles
Copy link
Contributor

@jasongrout Sure, let's do that. If this works for you, you can open a PR to update the REST endpoint, I will then take it over to update the UI. We can work on two separate branches or on a single one (easier). To work on a single branch, I have given you write access to https://github.com/datalayer-contrib/jupyterlab. We can do the work at another place if you prefer.

If design is not clear and a discussion is welcome, we can plan that a call on Monday.

@jasongrout
Copy link
Contributor Author

If you submit a PR and check the box to let maintainers contribute, we can both just push to that PR.

@jasongrout
Copy link
Contributor Author

you can open a PR to update the REST endpoint,

Oh, I guess I'm the one to first open a PR, then you should be able to just push to my PR.

@echarles
Copy link
Contributor

Oh, I guess I'm the one to first open a PR, then you should be able to just push to my PR.

Let's do that. Looking forward to you PR so I can contribute to it.

@jasongrout
Copy link
Contributor Author

Let's do that. Looking forward to you PR so I can contribute to it.

@echarles, an initial implementation of the API improvement is in #9390, if you want to take over and push to that PR (or if it's easier, merge that PR and follow up in a different PR). Thanks for working on the front end part of this!

@krassowski
Copy link
Member

Thank you everyone for working on this. I wonder if there are plans on improving the metadata utilisation, especially providing a link to the extension webpage/documentation. It seems that currently the prebuilt extensions are at disadvantage and the extension manager is not as helpful for them as for the node-based extensions (no description, no link, no pic):

Screenshot from 2021-01-03 01-57-19

Is this intended?

@jasongrout
Copy link
Contributor Author

Yes. This was the first step, and we invite help to make things better.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants