Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt extensions should use styleModule #9459

Closed
jasongrout opened this issue Dec 11, 2020 · 0 comments · Fixed by #9460
Closed

Prebuilt extensions should use styleModule #9459

jasongrout opened this issue Dec 11, 2020 · 0 comments · Fixed by #9460
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

In #9427, we introduced a new styleModule key instead of guessing about there being a js file corresponding to a style file. That change did not propagate to

if (data.style) {
let style = path.join(packagePath, data.style);
if (path.extname(style) === '.css') {
// See if there is a corresponding js file we can load instead
const jsFile = `${style.slice(0, style.length - 4)}.js`;
if (fs.existsSync(jsFile)) {
style = jsFile;
}
}
exposes['./style'] = style;
}

The above code should be updated to use the styleModule key.

@jasongrout jasongrout added this to the 3.0 milestone Dec 11, 2020
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 11, 2020
In jupyterlab#9427, we introduced a new styleModule key instead of guessing about there being a js file corresponding to a style file. That change did not propagate to prebuilt extensions. This commit fixes prebuilt extensions to use styleModule if available.

Fixes jupyterlab#9459
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant