Fix comment on PR action

[fcollonval]

Fix comment on PR action condition

Previously the jobs.upload.if condition was always true, leading to job failure when the upstream benchmark job was not successful.

Code changes

Correct job condition

User-facing changes

N/A

Backwards-incompatible changes

N/A

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[fcollonval]

It needs to be merged to check it will work.

[blink1073]

Thanks!

[github-actions]

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table

Test file	large_code_notebook	large_md_notebook
open
chromium
actual	6480 <- [6896 - 7190 - 7715] -> 8132	3025 <- [3160 - 3232 - 3341] -> 3940
expected	6570 <- [6773 - 7022 - 7609] -> 7899	2998 <- [3145 - 3210 - 3437] -> 3848
Mean relative change	1.4% ± 1.7%	-0.1% ± 1.8%
switch-from
chromium
actual	873 <- [941 - 1026 - 1116] -> 1853	504 <- [616 - 651 - 687] -> 875
expected	833 <- [923 - 987 - 1076] -> 1262	523 <- [625 - 659 - 690] -> 790
Mean relative change	4.0% ± 3.3%	-0.6% ± 2.3%
switch-to
chromium
actual	772 <- [809 - 832 - 862] -> 1011	608 <- [671 - 713 - 742] -> 804
expected	763 <- [796 - 813 - 838] -> 932	596 <- [697 - 723 - 746] -> 810
Mean relative change	2.4% ± 1.4%	-1.4% ± 1.9%
close
chromium
actual	837 <- [914 - 948 - 1004] -> 1330	581 <- [612 - 629 - 672] -> 821
expected	848 <- [917 - 954 - 1199] -> 1364	574 <- [613 - 635 - 706] -> 854
Mean relative change	-3.5% ± 3.7%	-0.5% ± 2.6%

Changes are computed with expected as reference.