Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tex highlights affecting Markdown with standalone $ #11488

Merged
merged 1 commit into from Nov 19, 2021

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Nov 17, 2021

References

Fixes #11482

Code changes

  • Adds a regular expression lookahead to the opening conditions for inline tex highlighting.
  • Adds visual regression test

User-facing changes

Before:

Screenshot from 2021-11-17 19-29-57

After:

Screenshot from 2021-11-17 19-27-00

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski !

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 7409 <- [7803 - 8149 - 8322] -> 8661 3577 <- [3766 - 3883 - 4084] -> 4250
expected 7278 <- [7587 - 8057 - 8239] -> 8726 3649 <- [3798 - 4027 - 4125] -> 4423
Mean relative change 1.4% ± 1.2% -1.5% ± 1.3%
switch-from
chromium
actual 924 <- [984 - 1106 - 1250] -> 1741 582 <- [635 - 857 - 923] -> 1028
expected 861 <- [957 - 1012 - 1201] -> 1606 592 <- [643 - 855 - 923] -> 1111
Mean relative change 5.7% ± 4.5% -0.5% ± 4.9%
switch-to
chromium
actual 1002 <- [1048 - 1067 - 1081] -> 1245 725 <- [826 - 864 - 891] -> 953
expected 946 <- [1029 - 1047 - 1065] -> 1314 746 <- [822 - 881 - 902] -> 953
Mean relative change 1.7% ± 1.0% -1.5% ± 1.7%
close
chromium
actual 1042 <- [1142 - 1204 - 1548] -> 1666 672 <- [715 - 731 - 755] -> 880
expected 1013 <- [1110 - 1159 - 1315] -> 1649 666 <- [716 - 729 - 747] -> 876
Mean relative change 6.5% ± 4.6% 0.9% ± 1.3%

Changes are computed with expected as reference.

@fcollonval fcollonval merged commit ee14367 into jupyterlab:master Nov 19, 2021
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Nov 19, 2021
jtpio pushed a commit that referenced this pull request Nov 22, 2021
…down with standalone `$`) (#11501)

* Backport PR #11488: Fix Tex highlights affecting Markdown with standalone `$`

* Update UI snapshots

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown syntax highlighting broken when standalone dollar ($) present
2 participants