Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the CI workflow for flaky tests #12341

Merged
merged 1 commit into from Apr 4, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 4, 2022

References

Remove the extra linuxjs-flaky-tests CI workflow, which was introduced in #9677 to avoid restarting all the checks if only some known flaky ones were failing.

But GitHub now has a built-in way to restart failed job so this workflow is not needed anymore:

image

Code changes

Remove unneeded CI workflow.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0 milestone Apr 4, 2022
@jtpio
Copy link
Member Author

jtpio commented Apr 4, 2022

The js-apputils and js-services checks are now run as "Linux JS Tests`" checks:

image

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtpio jtpio merged commit 57167b4 into jupyterlab:master Apr 4, 2022
@jtpio jtpio deleted the remove-flaky-workflow branch April 4, 2022 14:11
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 3400 <- [3602 - 3690 - 3808] -> 4179 2374 <- [2519 - 2587 - 2680] -> 2903
expected 3371 <- [3556 - 3632 - 3754] -> 4220 2373 <- [2497 - 2570 - 2646] -> 2943
Mean relative change 1.8% ± 1.2% 0.8% ± 1.2%
switch-from
chromium
actual 611 <- [651 - 687 - 821] -> 923 448 <- [501 - 862 - 901] -> 1014
expected 591 <- [641 - 671 - 800] -> 935 452 <- [488 - 838 - 883] -> 1144
Mean relative change 2.0% ± 3.6% 3.5% ± 8.2%
switch-to
chromium
actual 288 <- [345 - 358 - 375] -> 411 236 <- [261 - 271 - 281] -> 306
expected 280 <- [340 - 350 - 364] -> 427 240 <- [257 - 264 - 272] -> 297
Mean relative change 2.0% ± 2.0% 2.2% ± 1.4%
close
chromium
actual 819 <- [864 - 878 - 908] -> 980 434 <- [449 - 458 - 470] -> 518
expected 521 <- [846 - 859 - 880] -> 944 419 <- [444 - 453 - 465] -> 507
Mean relative change 4.2% ± 2.0% 1.2% ± 1.0%

Changes are computed with expected as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants