New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle missing preferredPath
from the page config
#12521
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Failing UI regression Extension Manager › Search
is not relevant. Thx @jtpio
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
@meeseeksdev please backport to 3.4.x |
… page config
…ig (#12522) Co-authored-by: Eric Charles <eric@datalayer.io>
References
Fixes #12297 (review)
This allows alternative lab-based applications like JupyterLite to not have to provide a
preferredPath
in the page config, since this might not be relevant in all cases.Code changes
Handle the case where
preferredPath
is missing from the page config.User-facing changes
Should be none for most users.
Backwards-incompatible changes
None