Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scripts linked to test #12654

Merged
merged 2 commits into from Jun 7, 2022
Merged

Conversation

fcollonval
Copy link
Member

References

See when working on #12495

Code changes

N/A

User-facing changes

N/A

Backwards-incompatible changes

N/A

@fcollonval fcollonval added this to the 4.0 milestone Jun 6, 2022
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@jtpio jtpio merged commit 97a8269 into master Jun 7, 2022
@jtpio jtpio deleted the maintenance/remove-broken-scripts branch June 7, 2022 11:31
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 17307 <- [17824 - 18071 - 18279] -> 19230 4059 <- [4312 - 4411 - 4598] -> 5605
expected 17259 <- [17627 - 17920 - 18199] -> 19237 4075 <- [4324 - 4428 - 4574] -> 5516
Mean relative change 0.7% ± 0.6% 0.6% ± 1.8%
switch-from
chromium
actual 726 <- [812 - 845 - 911] -> 1099 597 <- [643 - 663 - 692] -> 916
expected 757 <- [814 - 836 - 883] -> 1115 587 <- [641 - 669 - 702] -> 825
Mean relative change 1.7% ± 2.4% -0.1% ± 2.4%
switch-to
chromium
actual 474 <- [533 - 561 - 604] -> 674 981 <- [1052 - 1091 - 1158] -> 1425
expected 436 <- [539 - 569 - 598] -> 670 963 <- [1042 - 1083 - 1144] -> 1518
Mean relative change -0.1% ± 2.1% 0.8% ± 2.6%
close
chromium
actual 1285 <- [1421 - 1458 - 1494] -> 1690 694 <- [745 - 768 - 804] -> 920
expected 1323 <- [1389 - 1436 - 1475] -> 1632 691 <- [748 - 772 - 798] -> 914
Mean relative change 1.7% ± 1.3% 0.5% ± 1.7%

Changes are computed with expected as reference.

hbcarlos pushed a commit to hbcarlos/jupyterlab that referenced this pull request Jun 10, 2022
* Remove scripts linked to test

* Clean cell-toolbar-extension scripts
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants