New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdformat plugins #13335
Add mdformat plugins #13335
Conversation
Thanks for making a pull request to jupyterlab! |
@@ -51,6 +51,8 @@ repos: | |||
rev: 0.7.16 | |||
hooks: | |||
- id: mdformat | |||
additional_dependencies: | |||
[mdformat-gfm, mdformat-frontmatter, mdformat-footnote] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if it's possible to add these as dev
dependencies.
With prettier
it was possible to format markdown files automatically in IDEs like VS Code which was quite handy. I don't know if it's also done automatically with mdformat
or if it needs additional IDE configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should stick with Prettier for all but the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah maybe. Anyway we can have a look separately.
7b80cd0
to
d25bf94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Follow up to #13322, cf #13322 (review)
Code changes
Add some mdformat plugins to allow GitHub syntax.
User-facing changes
None
Backwards-incompatible changes
None