Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct dirty handling in notebook model #13358

Merged
merged 1 commit into from Nov 2, 2022
Merged

Correct dirty handling in notebook model #13358

merged 1 commit into from Nov 2, 2022

Conversation

fcollonval
Copy link
Member

References

Follow-up of #13317

Code changes

NotebookModel.dirty is not properly set when the state changes.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Oct 31, 2022
@fcollonval fcollonval added this to the 3.6.0 milestone Oct 31, 2022
@fcollonval fcollonval merged commit cfc7bf5 into jupyterlab:master Nov 2, 2022
@fcollonval fcollonval modified the milestones: 3.6.0, 4.0.0 Nov 2, 2022
@fcollonval fcollonval deleted the fix/notebook-state-management branch November 2, 2022 08:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@fcollonval fcollonval

Labels
bug pkg:notebook
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fcollonval