New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a unified editor search provider #13884
Create a unified editor search provider #13884
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krassowski
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
For example, if we had text: `test test test` and replaced first `test` with `a` it would now be `a tes|t test` where `|` indicates cursor position set by `_lastReplacementPosition` (at fifth character) which would lead to the last `test` being highlighted rather than the second-to-last one) and effectively one result being omitted in consecutive replacements.
…m:krassowski/jupyterlab into create-shared-search-provider-for-editors
0d78d40
to
3b40b0f
Compare
I've increased timeout on galata update workflow, let's see if this helps. bot please update galata snapshots |
bot please update galata snapshots |
bot can I very kindly ask to please update snapshots |
@krassowski I have the impression there is something about this PR breaking the update job. I ran the update job successfully on a recent PR yesterday: https://github.com/jupyterlab/jupyterlab/actions/runs/4172386115/jobs/7223418464 Did you try running the update for your new test locally? Hopefully that may give us some idea. |
@fcollonval no, it is not specific to this PR, see that the Galata update job also failed on another PR after this comment #13964 (comment) link to the cancelled (timed out) job:
The link you posted only shows documentation update. That works fine. The main galata one does not.
Yes, it works locally. |
Thanks for the additional cases; so it seems the latest job that succeed if from 5 days ago: https://github.com/jupyterlab/jupyterlab/actions/runs/4135509044/jobs/7148065705 - it uses the same Playwright version; so let's rule that out as sources for now. The jobs for this PR and the one you referenced have the same strange timeouts in the few jobs that got executed:
So many timeouts are unexpected when updating snapshots. But the worst is that the log is telling us it is updating documentation snapshots 🤯 I'll look to that locally. |
Ok this is my fault - in #13909 I updated the default playwright config and forget to update the |
bot please update galata snapshots |
@krassowski I gave a try to rebase this PR to fix the snapshots. But I was not able to get a proper branch 😕 I let you do it as I don't want to mess your repo. Sorry to not be able to help you more on this. |
bot please update galata snapshots |
Thanks for the help here, it is greatly appreciated! I am not sure if this will do it, if it still fails I will look into robustifying the completer test. |
Galata snapshots updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @krassowski
The UI test is due to flakiness but the JS test is legit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the patience Mike, let's merge this.
CI failure is unrelated.
References
Fixes #13283 and provides a tentative fix for #13885
Also fixes #13282
Code changes
Simplifies searching in file editor by removing
CodeMirrorSearchProvider
and replacing it with abstractEditorSearchProvider
which expects subclasses to defineeditor
andmodel
properties.CellSearchProvider
andFileEditorSearchProvider
now inherit from the newEditorSearchProvider
which is essentially identical to the oldCellSearchProvider
.User-facing changes
Searching in editor works reliably again.
Backwards-incompatible changes