Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run-cells snapshot #14388

Merged
merged 1 commit into from Apr 17, 2023
Merged

Fix run-cells snapshot #14388

merged 1 commit into from Apr 17, 2023

Conversation

krassowski
Copy link
Member

References

Incorrect snapshot was merged with #14344

I am not sure how to fix the underlying problem but it is tracked in #14385.

Code changes

None

User-facing changes

None

Backwards-incompatible changes

None

@krassowski krassowski added this to the 4.0.0 milestone Apr 16, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

fcollonval
fcollonval approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit c042b10 into jupyterlab:master Apr 17, 2023
79 of 80 checks passed
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 561 <- [657 - 686 - 725] -> 895 711 <- [1307 - 1360 - 1422] -> 1603
expected 564 <- [645 - 677 - 716] -> 959 726 <- [1324 - 1386 - 1439] -> 1561
Mean relative change ⚠️ 1.5% ± 2.6% -1.1% ± 3.8%
switch-from
chromium
actual 625 <- [760 - 780 - 808] -> 933 354 <- [396 - 425 - 454] -> 538
expected 708 <- [755 - 782 - 808] -> 1038 355 <- [412 - 433 - 458] -> 521
Mean relative change ⚠️ -0.8% ± 1.8% -1.7% ± 2.5%
switch-to
chromium
actual 1283 <- [1327 - 1350 - 1380] -> 1598 872 <- [935 - 954 - 971] -> 1062
expected 1277 <- [1329 - 1346 - 1370] -> 1634 903 <- [943 - 963 - 982] -> 1097
Mean relative change ⚠️ 0.6% ± 1.2% -1.4% ± 0.9%
close
chromium
actual 151 <- [162 - 173 - 180] -> 219 213 <- [231 - 240 - 256] -> 343
expected 149 <- [163 - 172 - 179] -> 266 208 <- [229 - 239 - 253] -> 284
Mean relative change ⚠️ 0.5% ± 2.4% 0.7% ± 2.1%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: +150 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentDeleted 1 +16 B
ContentString 1 +66 B
Detached Text 1 +79 B
FocusTracker 1 +276 B
ObservableList 1 +60 B
OutputArea 1 +1.4 kB
OutputAreaModel 1 +115 B
Promise 1 +19 B
PromiseDelegate 1 +128 B
ResizeHandle 1 +47 B
RestorablePool 1 +304 B
UndoManager 1 +1.93 kB
WidgetTracker 1 +980 B
YArray 1 +164 B
YCodeCell 1 +107 B
YText 1 +57 B
Detached DOMStringMap 2 +96 B
Detached V8EventHandlerNonNull 2 +80 B
Set 2 +1.21 kB
YMap 2 +464 B
StackItem 3 +1.32 kB
ContentAny 4 +238 B
ContentType 4 +64 B
DeleteItem 4 +80 B
DeleteSet 6 +988 B
Detached HTMLCollection 6 +576 B
EventHandler 8 +256 B
ID 10 +320 B
Item 10 +1.2 kB
Detached DOMTokenList 13 +860 B
Detached Attr 14 +1.12 kB
Detached HTMLDivElement 14 +47 kB
Map 17 +2.63 kB
Signal 19 +319 B
Detached V8EventListener 263 +23.4 kB
Detached EventListener 265 +42.6 kB
(closure) 270 +20.3 kB
Detached InternalNode 323 +45.3 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +1 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22
Create a markdown cell Memory change: -106 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +294 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +193 B
AttachmentsResolver 1 +14 B
CodeCellModel 1 +177 B
ContentString 1 +66 B
Debouncer 1 +3.46 kB
Detached HTMLAnchorElement 1 +316 B
Detached HTMLButtonElement 1 +5.32 kB
Detached HTMLHeadingElement 1 +1.04 kB
Error 1 +3.06 kB
MarkdownCell 1 +4.73 kB
MarkdownCellModel 1 +237 B
Poll 1 +3.7 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +66 B
Transaction 1 +860 B
TypeError 1 +312 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YCodeCell 1 +107 B
YMarkdownCell 1 +45 B
Detached CSSStyleDeclaration 2 +132 B
Detached HTMLElement 2 +336 B
Detached V8EventHandlerNonNull 2 +5.04 kB
Promise 2 +3.06 kB
PromiseDelegate 2 +3.27 kB
UndoManager 2 +2.38 kB
YText 2 +479 B
Detached DOMStringMap 3 +160 B
ObservableMap 3 +381 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 6 +498 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached Text 7 +532 B
Set 8 +1.78 kB
Detached HTMLDivElement 10 +30.8 kB
Detached DOMTokenList 13 +900 B
EventHandler 14 +448 B
ID 14 +448 B
Item 14 +1.84 kB
Detached HTMLCollection 17 +1.81 kB
Map 27 +12.4 kB
Signal 28 +594 B
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.5 kB
(closure) 152 +19.3 kB
Detached InternalNode 162 +28.5 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1352:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:427:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2745:15
Array +1 [c6ffd655-e985-4099-9596-5dbe30a6789c, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2560:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2555:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:355:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2676:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +14 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22
Create a raw cell Memory change: -174 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
CodeCellModel 1 +359 B
ContentString 1 +690 B
Detached CSSStyleDeclaration 1 +72 B
Detached V8EventHandlerNonNull 1 +40 B
ObservableMap 1 +109 B
TypeError 1 +306 B
YArray 1 +164 B
YCodeCell 1 +107 B
YRawCell 1 +45 B
Detached DOMStringMap 2 +100 B
Set 2 +1.31 kB
UndoManager 2 +2.38 kB
YText 2 +435 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
Detached HTMLCollection 5 +488 B
ContentAny 6 +498 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached DOMTokenList 9 +636 B
Detached HTMLDivElement 9 +22.7 kB
Signal 11 +450 B
EventHandler 14 +448 B
ID 14 +448 B
Item 14 +2.47 kB
Map 19 +11.5 kB
DOMRectReadOnly 32 +1.79 kB
Object 35 +185 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 140 +6.21 kB
Detached InternalNode 151 +21.7 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1352:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:427:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2745:15
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emit     http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Array +1 [fb3516c0-cbbc-45e1-9f17-a35157aba527, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2560:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2555:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:355:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2676:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +14 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22                                                                                  
- Drag and drop a cell

File editor memory leaks

Create a file Memory change: -80 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +3.14 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached ElementIntersectionObserverData 2 +144 B
Detached HTMLButtonElement 2 +24 kB
Detached SVGCircleElement 2 +1.12 kB
LabIcon 2 +1.08 kB
Detached CSSStyleDeclaration 3 +216 B
Detached HTMLLIElement 3 +6.21 kB
Detached NodeList 3 +184 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +109 B
Detached SVGGElement 4 +3 kB
VirtualElement 4 +945 B
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.81 kB
Detached SVGSVGElement 5 +8.18 kB
Detached HTMLSpanElement 6 +2.42 kB
Detached DOMStringMap 7 +432 B
Detached SVGAnimatedNumber 7 +448 B
Detached Attr 10 +800 B
Detached Text 10 +1 kB
Detached HTMLCollection 13 +1.47 kB
Detached DOMTokenList 14 +940 B
Detached HTMLDivElement 15 +33.7 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +22.4 kB
✔ Opening a text file (76295ms)

Notebook memory leaks

Create a notebook Memory change: +23.3 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.36 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +55 B
Detached ElementIntersectionObserverData 2 +144 B
Detached HTMLButtonElement 2 +23.7 kB
Detached SVGCircleElement 2 +1.12 kB
HTMLDivElement 2 +97 B
LabIcon 2 +85 B
Detached CSSStyleDeclaration 3 +224 B
Detached HTMLLIElement 3 +6.2 kB
Detached NodeList 3 +192 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +108 B
VirtualElement 4 +1.13 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.39 kB
Detached HTMLSpanElement 6 +3.1 kB
Detached SVGGElement 6 +5.02 kB
Detached SVGPathElement 7 +2.53 kB
Detached SVGAnimatedNumber 9 +576 B
Detached Attr 10 +800 B
Detached Text 10 +788 B
Detached HTMLCollection 13 +1.37 kB
Detached DOMTokenList 15 +944 B
Detached HTMLDivElement 15 +33.6 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
Array 21 +24.2 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +33.6 kB
✔ Opening a notebook (80936ms)

2 passing (7m)
1 pending
1 failing

   Adding a cell:

  AssertionError: expected false to equal true
  + expected - actual

  -false
  +true
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:35:12
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@krassowski krassowski

Labels
maintenance tag:Testing
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krassowski @fcollonval