Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-rendering if initial completer load has a subset match for all available options. #1778

Merged
merged 11 commits into from Mar 1, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Feb 23, 2017

  • Fixes #1768
  • Fixes an issue where the tab key interferes with completer behavior if tab is set as the invocation shortcut to bring up a completer and a completer session is already active
  • Fixes an issue where completer did not properly invoke if a document had been loaded but no text in the document had been changed before completer invocation (thanks @ian-r-rose)
  • Fixes an issue where the enter key was caught in contention between console/notebook commands and completer item selection
  • Simplified the heuristic for when completer invocation should be ignored: only empty whitespace lines are ignored, all other invocations are sent to the kernel because this is the behavior of the classic notebook and some language kernels require it (cheers @Carreau). This behavior may be tweaked in the future.
Copy link
Member

@blink1073 blink1073 left a comment

Nice!

@blink1073 blink1073 merged commit 1d18ad9 into jupyterlab:master Mar 1, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Mar 1, 2017
@afshin afshin deleted the pr-1768 branch Jul 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants