Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single document UI #2037

Merged
merged 21 commits into from Apr 13, 2017
Merged

Single document UI #2037

merged 21 commits into from Apr 13, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Apr 11, 2017

This PR:

  • Rationalizes the ranking of items in the left sidebar. The default rank is 500, and all the JupyterLab components that add themselves to the left sidebar pick increments of 100.
  • Enables multiple-document and single-document modes for the main application dock panel.
  • Creates a tab manager in the left sidebar to show all open documents regardless of what mode the application is in, allowing users to switch documents even in single-document mode.
  • The application mode can be toggled with:
    • A global keyboard shortcut, currently: Accel Shift Enter
    • A command in the command palette (its label toggles based on current mode)
  • The application mode is part of the state that gets restored upon refresh.

cc: @jasongrout @ellisonbg @cameronoelsen

@afshin afshin added this to the Beta milestone Apr 11, 2017
@afshin afshin self-assigned this Apr 11, 2017
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 11, 2017

CC @ivanov

@@ -174,7 +156,7 @@ class ApplicationShell extends Widget {
}

/**
* Activate a widget in it's area.
* Activate a widget in its area.
Copy link
Contributor

@jasongrout jasongrout Apr 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@afshin
Copy link
Member Author

@afshin afshin commented Apr 11, 2017

A notebook in SDI mode

notebook sdi

A terminal in SDI mode

terminal sdi

The mode toggling command

command

@afshin
Copy link
Member Author

@afshin afshin commented Apr 11, 2017

The styles still need some tweaking and the behaviors have not been implemented yet, but the semantics of this UI are: there's a "Tabs" list in the left sidebar and it allows you to set the current document even in single-document mode:

screen shot 2017-04-11 at 9 24 44 pm

cc: @ellisonbg @jasongrout @cameronoelsen @ivanov if you have any feedback, I'd appreciate it!

@afshin afshin force-pushed the single-document branch from 37acc15 to 0dd36e2 Apr 11, 2017
@afshin afshin force-pushed the single-document branch from b65090b to 89b4a19 Apr 13, 2017
@afshin afshin force-pushed the single-document branch from efdcb1f to b72873d Apr 13, 2017
@afshin afshin force-pushed the single-document branch from 4e5fbf2 to 6e6d2f4 Apr 13, 2017
… manager only switches tabs, does not toggle mode.
@afshin afshin force-pushed the single-document branch from 2ec90b0 to c30cbc5 Apr 13, 2017
Copy link
Member

@blink1073 blink1073 left a comment

Nice!

@blink1073 blink1073 merged commit f11e1e3 into jupyterlab:master Apr 13, 2017
2 checks passed
@willingc
Copy link
Contributor

@willingc willingc commented Apr 13, 2017

Thanks @afshin! I'm looking forward to trying this out 😄

@blink1073 blink1073 mentioned this pull request Apr 21, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants