Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FooWidget -> Foo (rebased) #2177

Merged
merged 21 commits into from May 10, 2017
Merged

Rename FooWidget -> Foo (rebased) #2177

merged 21 commits into from May 10, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 10, 2017

Fixes #2090

We have decided to not use Widget in the names of Widget subclasses anymore.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 10, 2017

I verified the affected widgets work as intended, and fixed missing styling on the CSV viewer toolbar.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 10, 2017

Thanks, once the tests pass, I will merge!

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented May 10, 2017

Docs test failure is expected (chicken and egg problem), merging.

@blink1073 blink1073 merged commit 2cf3ee4 into jupyterlab:master May 10, 2017
1 of 2 checks passed
@blink1073 blink1073 deleted the pr/2166 branch May 16, 2017
@blink1073 blink1073 mentioned this pull request May 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants