Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server settings #2185

Merged
merged 45 commits into from May 16, 2017
Merged

Server settings #2185

merged 45 commits into from May 16, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 11, 2017

Cleans up the handling of server settings in services. Separates the requests and kernel/session options from the server settings. Consolidates the handling of these server settings and allows the XML object the WebSocket to be overridden without setting them in the global context.

Fixes #2182.

@blink1073 blink1073 changed the title [WIP] Server settings Server settings May 15, 2017
afshin
afshin approved these changes May 16, 2017
Copy link
Member

@afshin afshin left a comment

Awesome, thanks!

👍

@afshin afshin merged commit cc53996 into jupyterlab:master May 16, 2017
2 checks passed
@blink1073 blink1073 deleted the server-settings branch May 16, 2017
@blink1073 blink1073 mentioned this pull request May 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants