Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kernel name toolbar indicator to button that switches kernel #2195

Merged
merged 3 commits into from May 11, 2017

Conversation

@markroth8
Copy link
Contributor

@markroth8 markroth8 commented May 11, 2017

Fixes second part of #919.

Changes the Kernel name in the toolbar to a button that, when clicked, displays the "Switch Kernel" dialog.

Needed to add a spacer because the kernel name label presently takes up the remaining whitespace on the toolbar which would make the button look huge.

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 11, 2017

Nice! @eskirk, I prefer this to the context menu approach because it is more discoverable: see hover screenshot:

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 11, 2017

Ah, we have a test failure: https://travis-ci.org/jupyterlab/jupyterlab/jobs/231263945#L4138
This is the test:

describe('#populateDefaults()', () => {
.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 11, 2017

Sitting here working with @markroth8 - I too think I prefer the button to the dropdown...

@markroth8
Copy link
Contributor Author

@markroth8 markroth8 commented May 11, 2017

That teaches me to assume such a change can't possibly break tests!

* from the right toolbar items.
*/
export
function createSpacerItem(session: IClientSession): Widget {
Copy link
Contributor

@ellisonbg ellisonbg May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the spacer needs the session passed in.

Copy link
Contributor Author

@markroth8 markroth8 May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True.

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 11, 2017

Thanks again!

@blink1073 blink1073 merged commit e6a4655 into jupyterlab:master May 11, 2017
2 checks passed
@markroth8 markroth8 deleted the switch-kernel-session branch May 11, 2017
@blink1073 blink1073 mentioned this pull request May 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants