Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting hub app over to lab #2222

Merged
merged 1 commit into from May 16, 2017
Merged

Porting hub app over to lab #2222

merged 1 commit into from May 16, 2017

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 16, 2017

This will make it much easier for users/devops folks to run lab with JuptyerHub as it allows the jupyterhub-lab extension to be pure npm/js code:

https://github.com/jupyterhub/jupyterlab-hub

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented May 16, 2017

@ellisonbg ellisonbg added this to the Beta milestone May 16, 2017
@blink1073
Copy link
Member

@blink1073 blink1073 commented May 16, 2017

Looks good to me, thanks!

@blink1073 blink1073 merged commit 60dabb2 into jupyterlab:master May 16, 2017
2 checks passed
@danielballan
Copy link
Collaborator

@danielballan danielballan commented May 16, 2017

Makes sense. It's nice to know that it was possible to make this work without adding hub-specific code to jupyterlab, but doing so certainly makes things simpler on the hub side.

@blink1073 blink1073 mentioned this pull request May 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants