Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher refactor #2380

Merged
merged 22 commits into from Jun 10, 2017
Merged

Launcher refactor #2380

merged 22 commits into from Jun 10, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 6, 2017

Fixes #2330.

  • Remove landing extension and launcher side bar.
  • Update launching behavior for terminal, console, notebook, and editor.
  • Replace launcher tab with the opened widget.
  • Removed the palette items for new text file and notebook.
  • Create menu item for New....
  • Properly sort items.
  • Update filebrowser buttons to use toolbar and call launcher.
  • Add a File -> Rename with dialog.
  • Add a right click handler on file titles with rename.
  • Add logo and version if displayed as "landing page".
  • Pick convenient keybinding for the new action.

@blink1073 blink1073 added this to the Beta milestone Jun 6, 2017
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 7, 2017

Let me know when this is ready for review...no hurry, just willing to help in any way I can

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

Update: the launching behavior is done for terminal, console, notebook, and editor. The launcher tab is replaced with the opened widget.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

@ian-r-rose, FYI I am about to use expose a toolbar in the file browser.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 7, 2017

Awesome, I will abandon a branch that does that!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 7, 2017

Did an initial UX review of this:

  • Very, very cool overall, will be a huge improvement.
  • Having a keyboard shortcut for "New" will make it even easier.
  • We may want to have a CSS class that is applied to "Sections" of activities (notebooks, consoles, etc). That way, we can do conditional styling/design later.
  • Eventually (post beta) we may want to allow visual sectionings of the items, or different ways of sorting the items. At least having a notion of "setion" in the API would be a help at this point (you may already have it in the code, I haven't looked yet).

We can have @cameronoelsen take a pass on the design side once this is merged, so I wouldn't spend too much time on that side of it - already though, the visual design is super solid and usable.

Will you need a "new folder" icon for the filebrowser toolbar? if so, @cameronoelsen can you create one? I know you had worked on that before so it may be mostly done.

This is fantastic!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 7, 2017

Also, how are you sorting the items?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

We have a section, but no associated class applied yet. We don't yet have icons for new file or new folder (nor are they in font-awesome), so I was going to use a single + and add a New Folder item in the file menu.

We are currently sorting by rank, then section, then displayName.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 7, 2017

Does the launcher make a distinction between file-backed activities and non-file-backed activities?

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

No, they are treated the same.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

I put a placeholder in for now for the new folder, since File -> New Folder would only apply to the main file browser.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

Rename dialog:

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 7, 2017

Variations of Accel T and Accel N are intercepted by the browser:

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 8, 2017

@ellisonbg this is ready for review, I can add the "landing" page behavior in a follow on PR.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 8, 2017

Finished the landing page (shown after app restore when there are no open widgets):

@blink1073 blink1073 changed the title [WIP] Launcher refactor Launcher refactor Jun 8, 2017
@blink1073 blink1073 mentioned this pull request Jun 9, 2017
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 10, 2017

OK, reviewing now!

Copy link
Contributor

@ellisonbg ellisonbg left a comment

I did a local checkout and everything worked beautifully! This is a huge improvement over the previous model. While we may want to make minor tweaks over time, this foundation is really solid and will solve most of the awkwardness of this part of the UX. I also looked through the code quickly and it looked fine. A lot of the implementation will be be simplified by the upcoming vdom work on toolbars, buttons, etc. I am going to merge, so we can iterate and keep things moving. Great work!

*
* The default value is the an empty string.
*/
category?: string;
Copy link
Contributor

@ellisonbg ellisonbg Jun 10, 2017

The only think I can imagine adding here later is a field for the kernel name. That could let us sort by category or kernel later. But we can always add that later.

@ellisonbg ellisonbg merged commit e27b763 into jupyterlab:master Jun 10, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Jun 14, 2017
@blink1073 blink1073 deleted the launcher-refactor branch Jul 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants