Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborative saving #2387

Merged
merged 2 commits into from Jun 7, 2017
Merged

Collaborative saving #2387

merged 2 commits into from Jun 7, 2017

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jun 7, 2017

Improves user experience around autosaving of collaborative documents (most notably, does not warn on timestamp conflict).

@@ -38,6 +38,7 @@ class SaveHandler implements IDisposable {
this._context = options.context;
this._minInterval = options.saveInterval * 1000 || 120000;
this._interval = this._minInterval;
this._warnOnConflict = this._context.model.modelDB.isCollaborative;
Copy link
Member

@blink1073 blink1073 Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the opposite logic?

Copy link
Member Author

@ian-r-rose ian-r-rose Jun 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, you are right. Mismatch between the name and the intent (though it currently has the right behavior). Fixing now.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 7, 2017

Thanks!

@blink1073 blink1073 merged commit 6dfb6fd into jupyterlab:master Jun 7, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Jun 14, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants