Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language and tab editor settings #2406

Merged
merged 3 commits into from Jun 13, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 8, 2017

Partially addresses #2382. Fixes #2351.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 10, 2017

Great! A few possible changes:

  • Group the items in the Editor menu by whether or not they are per file or global. I would put the per file ones at the top, then a separator, and then the global/settings ones.
  • Maybe only include 1,2,4,8 space indent options?
  • Add the indent options to the Editor command palette.

I did test with a dockerfile and a Makefile and it completely solves the pain point with those file types!

Copy link
Contributor

@ellisonbg ellisonbg left a comment

See above post on changes requested.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 12, 2017

Updated

@ellisonbg ellisonbg merged commit a49b65a into jupyterlab:master Jun 13, 2017
2 checks passed
@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jun 13, 2017

Hey what about us who use 3 spaces?

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Jun 13, 2017

(just kidding, thank you for getting this in!)

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 13, 2017

\me throws shoe

@blink1073 blink1073 mentioned this pull request Jun 14, 2017
@blink1073 blink1073 deleted the fileeditor-settings branch Jul 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants