Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension Compatiblity #2410

Merged
merged 20 commits into from Jun 15, 2017
Merged

Extension Compatiblity #2410

merged 20 commits into from Jun 15, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 8, 2017

Fixes #2356.

Note: Populated the singletonPackages using the packages that export a token and @phosphor/widgets, which comprises the packages that are explicitly shared.

Sample output:

ValueError:
"@jupyterlab/python-tests@0.1.0" is not compatible with the current JupyterLab
Conflicting Dependencies:
Required	Actual	Package
^0.6.0  	^0.5.0	@jupyterlab/application

TODO:

  • Update the release script to add the explicit deps from the listed extensions
  • Use those deps along with singleton packages config to determine compat
  • Use the compat information in list - show as invalid, offer verbose mode with full report
  • Use the compat information when building - remove from templated package.json
  • Add tests
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 9, 2017

Going to wait until #2409 is merged to finish this, since there will be a lot of overlap.

@blink1073 blink1073 force-pushed the extension-compat branch from 34f27e8 to b6f35ed Jun 14, 2017
@blink1073 blink1073 changed the title [WIP] Extension Compatiblity Extension Compatiblity Jun 14, 2017
@blink1073 blink1073 mentioned this pull request Jun 14, 2017
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2017

Trying some things out with this branch:

First I ran:

jupyter labextension uninstall @jupyterlab/help-extension

I then saw this:

(python34) $ jupyter labextension list
[ListLabExtensionsApp] JupyterLab v0.23.2
[ListLabExtensionsApp] Known labextensions:
[ListLabExtensionsApp] 
Uninstalled core extensiosn:
[ListLabExtensionsApp]     @jupyterlab/help-extension

But when I tried to install that extension again I got a Python exception that ended with:

ValueError: @jupyterlab/help-extension is not a valid JupyterLab extension

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2017

I tried to link/unlink the mockextension and mockextension-incompat and it all worked as expected.


# Handle uninstalled and disabled core packages
uninstalled_core = _get_uinstalled_core_extensions(app_dir)
if uninstalled_core:
print('\nUninstalled core extensiosn:')
[print(' %s' % item) for item in sorted(uninstalled_core)]
logger.info('\nUninstalled core extensiosn:')
Copy link
Contributor

@ellisonbg ellisonbg Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensiosn

@blink1073 blink1073 force-pushed the extension-compat branch from 4221c8a to c5ef47e Jun 15, 2017
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2017

Tested latest changes locally and all is happy. Once the tests pass, let's merge!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2017

Come on Travis!

@ellisonbg ellisonbg merged commit cc55794 into jupyterlab:master Jun 15, 2017
1 of 2 checks passed
@blink1073 blink1073 deleted the extension-compat branch Jul 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants