Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON schema for settings. #2411

Merged
merged 51 commits into from Jun 27, 2017
Merged

Use JSON schema for settings. #2411

merged 51 commits into from Jun 27, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Jun 9, 2017

No description provided.

}

/**
* Populate the fieldset with a specific plugin's metaata.
Copy link
Member

@blink1073 blink1073 Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata*

*/
function getHint(key: string, registry: ISettingRegistry, plugin: ISettingRegistry.IPlugin): string {
// First, give priorty to checking if the hint exists in the user data.
let hint = plugin.data.user[key];
Copy link
Member

@blink1073 blink1073 Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be plugin.data.user && plugin.data.user[key];, and plugin.data.composite && plugin.data.composite[key]; below.

Copy link
Member Author

@afshin afshin Jun 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this upstream.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 27, 2017

Looks great, thanks!

@blink1073 blink1073 merged commit 231e201 into jupyterlab:master Jun 27, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Jul 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants