Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatable Outputs #2439

Merged
merged 9 commits into from Jun 15, 2017
Merged

Updatable Outputs #2439

merged 9 commits into from Jun 15, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jun 13, 2017

Fixes #1227. Fixes #629.

Verified using Min's notebook:

Now that futures are kept alive until the next execution, we get threaded messages (#629):

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 14, 2017

Update: this is now working, it needs tests.

@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jun 15, 2017

Hooray! Thank you!

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jun 15, 2017

Tested locally with Min's notebook and it works as expected! Nice!

@blink1073 blink1073 changed the title [WIP] Updatable Outputs Updatable Outputs Jun 15, 2017
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jun 15, 2017

cc @minrk, riding on your coattails 😄

Copy link
Contributor

@ellisonbg ellisonbg left a comment

With tests in place, and my previous local test. This is ready to go. Waiting for Travis to make sure the tests are happy though.

@blink1073 blink1073 force-pushed the updatable-outputs branch from 50df87a to c8a098a Jun 15, 2017
@blink1073 blink1073 merged commit 7f3d38d into jupyterlab:master Jun 15, 2017
2 checks passed
@rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jun 15, 2017

Fannnnntastic

@blink1073 blink1073 mentioned this pull request Jun 15, 2017
@blink1073 blink1073 deleted the updatable-outputs branch Jul 10, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants