Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishes refactor/design of launcher #2580

Merged
merged 11 commits into from Jul 5, 2017

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Jul 5, 2017

After:

screen shot 2017-07-04 at 8 03 32 pm

@ellisonbg ellisonbg added this to the Beta milestone Jul 5, 2017
@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Jul 5, 2017

Fixes #2468

Still some cleanup to the code side, so not ready for merge.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 5, 2017

We aren't handling long kernel names well:

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Jul 5, 2017

There is a tooltip that will show the entire kernel name, so we don't need to show the full name in the card, but that definitely needs improvement. Will work with Cameron on it today.

@ellisonbg ellisonbg merged commit a6dc6e6 into jupyterlab:master Jul 5, 2017
2 checks passed
@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Jul 5, 2017

Merge and iterate!!!

@blink1073 blink1073 mentioned this pull request Jul 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants