Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle file types in document registry #2701

Merged
merged 23 commits into from Jul 21, 2017
Merged

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jul 17, 2017

Fixes #2594.

Adds better utilization of IFileType across the application.

  • Used by widget factories instead of raw file extensions
  • Used by mime extensions to establish new file types
  • Used by the file listing to choose a file icon
  • Adds support for pattern in IFileType for matching file names

Also cleans up the handling of the default text model factory for the registry.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jul 17, 2017

afshin
afshin approved these changes Jul 18, 2017
afshin
afshin approved these changes Jul 21, 2017
Copy link
Member

@afshin afshin left a comment

Awesome, thanks! Now we can support weird file types like Makefile, Rakefile, Dockerfile, etc., that do not have file extensions.

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Jul 21, 2017

Yep, after this PR a Dockerfile is opened with the right syntax highlighting automatically.

@blink1073 blink1073 merged commit e5d548c into jupyterlab:master Jul 21, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Jul 21, 2017
@blink1073 blink1073 deleted the file-types branch Aug 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants