Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for removing characters that should be overwritten by carriage returns and backspace characters. #2761

Merged

Conversation

@matthewwardrop
Copy link
Contributor

@matthewwardrop matthewwardrop commented Jul 28, 2017

This pull request fixes #1104, which has been the main reason I have not been able to use JupyterLab on a day-to-day basis.

This brings forward from Jupyter Notebook logic around removing characters that should be affected by backspaces and carriage returns. The logic I have employed here is "more correct" than that in Jupyter notebook, but as far as I can tell, my approach behaves more like one would expect.

This is my first time coding in TypeScript, and contributing to Jupyter Lab, so please direct me in anything necessary to see this merged :).

@matthewwardrop matthewwardrop force-pushed the mw_fix_overwritten_characters branch from 144d5d7 to fee5bf0 Jul 28, 2017
@sccolbert
Copy link
Contributor

@sccolbert sccolbert commented Jul 28, 2017

Thanks for jumping in and contributing!

@sccolbert
Copy link
Contributor

@sccolbert sccolbert commented Jul 28, 2017

We have some ongoing work in the output area on a branch right now, and these changes will conflict with that. I suggest we leave this open until that feature branch is merged, then make the necessary updates to this PR.

@matthewwardrop
Copy link
Contributor Author

@matthewwardrop matthewwardrop commented Jul 28, 2017

@sccolbert I can live with that. Which branch are we talking about?

@sccolbert
Copy link
Contributor

@sccolbert sccolbert commented Jul 28, 2017

feature-redux (it's very much still under churn, with lots of unpushed local changes).

@matthewwardrop
Copy link
Contributor Author

@matthewwardrop matthewwardrop commented Jul 28, 2017

nods. I know what that is like. Ping me on this PR when I can rebase my changes :).

@matthewwardrop
Copy link
Contributor Author

@matthewwardrop matthewwardrop commented Aug 9, 2017

@sccolbert Almost ready for me to get this into rebased and merged? Super keen to get this more widely deployed. It's been working great in my use case, but getting peers to deploy it off a branch is suboptimal :).

@sccolbert
Copy link
Contributor

@sccolbert sccolbert commented Aug 9, 2017

@matthewwardrop Not yet. This will probably have to go in post-beta release.

@matthewwardrop matthewwardrop force-pushed the mw_fix_overwritten_characters branch from fee5bf0 to 9a2b6d4 Aug 25, 2017
@matthewwardrop
Copy link
Contributor Author

@matthewwardrop matthewwardrop commented Aug 30, 2017

@sccolbert With the delay of the beta, any chance of getting this into the Beta version?

@matthewwardrop matthewwardrop force-pushed the mw_fix_overwritten_characters branch from 9a2b6d4 to f1dc3cf Oct 17, 2017
@blink1073 blink1073 added this to the Beta milestone Dec 3, 2017
@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 3, 2017

Thanks for this @matthewwardrop! Given that we're moving #2540 to the 1.0 release, we're ready to make this change for beta.

@blink1073 blink1073 merged commit 35ab49c into jupyterlab:master Dec 3, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 3, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants