Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build system and extension IDs to allow disabling/overriding of extensions. #2936

Merged
merged 49 commits into from Oct 5, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Aug 28, 2017

Changes extension ids to have the form package-name:plugin-name, with schema files taking the form plugin-name.json in the schemaDir. We now store the schemas in a nested structure by package name (including scoped packages).
Adds a @jupyterlab/buildutils package that for now only provides a mechanism to validate the extensions used and extract their schema and theme files to an appropriate location.
We use the new package from the jupyterlab/, examples/app, and JupyterLab app-dir so we do not repeat the logic anywhere.

@afshin afshin force-pushed the disabled-extensions branch from 017ddd7 to e9a6374 Oct 4, 2017
@afshin afshin force-pushed the disabled-extensions branch from b8fca89 to 3d8991d Oct 5, 2017
@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 5, 2017

Thanks!

@blink1073 blink1073 merged commit a36639e into jupyterlab:master Oct 5, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Oct 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.