Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Watch Mode #3077

Merged
merged 5 commits into from Oct 12, 2017
Merged

Implement Watch Mode #3077

merged 5 commits into from Oct 12, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 9, 2017

Fixes #3041.

  • Implement for app_dir
  • Implement for dev-mode
  • Update docs
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Oct 10, 2017

Oh. Man. I just tried this for dev mode, edited packages/codemirror/style/index.css and the new bundle was ready in 508ms.

@blink1073 blink1073 changed the title [WIP] Implement Watch Mode Implement Watch Mode Oct 10, 2017
@blink1073 blink1073 removed this from the Beta milestone Oct 12, 2017
@blink1073 blink1073 added this to the 0.28 milestone Oct 12, 2017
afshin
afshin approved these changes Oct 12, 2017
@afshin afshin merged commit 07a1d2b into jupyterlab:master Oct 12, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Oct 12, 2017
@blink1073 blink1073 deleted the app-watch-mode branch Oct 13, 2017
@echarles
Copy link
Contributor

@echarles echarles commented Apr 19, 2018

@blink1073 I have linked my extension with jupyter labextension link . and watched with yarn watch from that extension folder.

  1. Scenario 1: Run from jupyterlab folder with jupyter lab --watch => extension is show but not the Kernels (empty launcher page).
  2. Scenario 2: Run from jupyterlab folder with jupyter lab --dev-mode --watch => extension is not show but the kernels are listed in the launcher page.

Is this the expected behavior? I would love having my extension being watched and shown with the launcher page populated with kernels.

PS. Kudos for the awesomeness!

@echarles
Copy link
Contributor

@echarles echarles commented Apr 19, 2018

@blink1073 as workaround to achieve my goal (watching kernel+my_extension), i have tuned the package.json of the dev_mode folder and run with '--dev-mode' flag.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants