Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings with comments #3167

Merged
merged 91 commits into from Nov 28, 2017
Merged

Settings with comments #3167

merged 91 commits into from Nov 28, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Oct 30, 2017

  • Allows arbitrary serializable data being stored in the state database.
  • Adds support for JSON with comments raw settings being loaded from the back-end in the setting registry. (Depends on jupyterlab/jupyterlab_server#25)
  • Individual settings can still be updated/saved without compromising the JSON comments.
  • Inspection handlers are now instantiated with an IDataConnector, which means that arbitrary sources can populate an inspector, whether it is the global inspector or a local instance (as in the case of the raw settings editor).
  • Completion handlers are now instantiated with an IDataConnector, which means that arbitrary sources can populate text completion.

settings-with-comments

@afshin afshin self-assigned this Oct 30, 2017
@afshin afshin force-pushed the settings-with-comments branch from c3ad726 to 52a79d3 Oct 31, 2017
@afshin afshin force-pushed the settings-with-comments branch 5 times, most recently from 8416766 to 7112dda Nov 7, 2017
@afshin afshin force-pushed the settings-with-comments branch 2 times, most recently from 1b37c62 to 6e10640 Nov 10, 2017
@afshin afshin force-pushed the settings-with-comments branch 4 times, most recently from cd895e5 to 5c52631 Nov 15, 2017
@afshin afshin force-pushed the settings-with-comments branch from b84640a to 0018ec4 Nov 20, 2017
@afshin afshin force-pushed the settings-with-comments branch from f4a9f6c to 95d5f10 Nov 26, 2017
@afshin afshin force-pushed the settings-with-comments branch from dbdd06c to d00dcb1 Nov 27, 2017
}

/**
* Receive a completion reply from the kernel.
Copy link
Member

@blink1073 blink1073 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*from the connector

import {
DataConnector
} from '@jupyterlab/coreutils';
import {
Copy link
Member

@blink1073 blink1073 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line

@@ -223,13 +198,49 @@ namespace InspectionHandler {
export
interface IOptions {
/**
* The client session for the inspection handler.
* The connector used to make inspection requests.
* #### Notes
Copy link
Member

@blink1073 blink1073 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line

/**
* The toolbar commands and registry for the setting editor toolbar.
*/
commands: {
Copy link
Member

@blink1073 blink1073 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misaligned and missing new line

Copy link
Member Author

@afshin afshin Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commands is an object that is a child attribute of the IOptions

/**
* The toolbar commands and registry for the setting editor toolbar.
*/
commands: {
Copy link
Member

@blink1073 blink1073 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent and new line

Copy link
Member Author

@afshin afshin Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 28, 2017

Very nice, thanks!

@blink1073 blink1073 merged commit d8fe2c3 into jupyterlab:master Nov 28, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 2, 2017
@afshin afshin deleted the settings-with-comments branch Feb 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants