Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Menu updates #3344

Merged
merged 44 commits into from Dec 17, 2017
Merged

[WIP] Menu updates #3344

merged 44 commits into from Dec 17, 2017

Conversation

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Dec 8, 2017

This is round two of revamping the menus (cf #3103) in JupyterLab, after #3182, and after more discussions with @jasongrout and the Bloomberg UX team.
It does:

  1. Reorders a bunch of things
  2. Adds a Save All command.
  3. Changes from using file names to file types in menu labels.
  4. Restores the "New Launcher" menu item.
  5. Restores "New Terminal" and "New Console" to the command palette.
  6. Adds commands for selecting and deselecting all notebook cells.
  7. Adds commands for pasting above and paste-replace-ing cells.
  8. Adds a "Clear current" semantic item to the IEditMenu.IClearer
  9. Adds more hide/show commands for the notebook to the View menu.
  10. Only enable "Split Cell" in edit mode.
  11. Remove "Insert Line Break" as a confusing menu item. It is still discoverable in the Console section of the command palette.
  12. Creates a new Tab menu for application-level window manipulation things. The Tab menu contains a list of currently active tabs in the main area.
  13. Restart and clear outputs has been restored.
  14. Restart and run all has been restored.
  15. New Console For... has been moved into a group with New View for...
  16. New Settings menu, for menu items that interact with the setting registry.
  17. The Settings menu and Command Palette now have commands for switching JupyterLab themes.

Todo in a followup PR: Editor settings need some clarification. Which settings should be on a per-widget basis, and which settings should be global? Can we make some of the same settings apply to both the notebook and text editors? My current thinking is that the defaults should be stored in the settings registry, but then should be overridable on a per-widget basis.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 8, 2017

Only 9 things? 😜

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Dec 8, 2017

And counting.

@ian-r-rose ian-r-rose force-pushed the menu-updates branch 5 times, most recently from 0e2d60a to 50d60d0 Dec 12, 2017
@dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Dec 13, 2017

Loving the new menus & looking forward to the next iteration! 👍

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Dec 16, 2017

Copy link
Member

@blink1073 blink1073 left a comment

Pending the changes to the Tabs menu behavior, I think this is ready for a merge and iterate.

@blink1073 blink1073 added this to the Beta milestone Dec 17, 2017
@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Dec 17, 2017

I have restored the tab side bar. I have been doing some playing with fixes for the autoClosingBrackets behavior, but that can be in a followup PR.

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Dec 17, 2017

One thing that the Bloomberg UX folks have stressed is to not have UI elements only show up in certain contexts (for instance, they complained about the behavior of the Cell Tools tab). For that reason, I would propose just keeping the Tabs side bar visible.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 17, 2017

@ian-r-rose
Copy link
Member Author

@ian-r-rose ian-r-rose commented Dec 17, 2017

In that case this should be good to go (pending comments on the code itself).

Copy link
Contributor

@ellisonbg ellisonbg left a comment

I am not the right person to review the code changes. I did glance at the code though. From a UX perspective, it looks great. I checked it out locally and played with it. It is a good representation of all the work and discussions we have had. From the UX perspective I am fine with this being merged, but someone should look at the code first.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 17, 2017

LGTM, thanks!

@blink1073 blink1073 merged commit 8289c28 into jupyterlab:master Dec 17, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 23, 2017
1 task
@ian-r-rose ian-r-rose mentioned this pull request Sep 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants