Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console style work for beta #3418

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@ellisonbg
Copy link
Contributor

commented Dec 19, 2017

Talked with Jason and the Bloomberg design folks today about the console design. Here is a summary:

  • When content is not editable (as in console cells that have been run) avoid using visual treatment of form fields (border + shaded bg).
  • Using same background as notebook will ensure outputs looks the same in both. Some outputs (such as transparent images) are influenced by the background color. We can't prevent this, so at least make it the same in both.

Here is the state of this PR...

Light theme:

screen shot 2017-12-18 at 7 12 36 pm

Dark theme using matplotlib dark_background style:

screen shot 2017-12-18 at 7 13 01 pm

@blink1073

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

Thanks!

@blink1073 blink1073 merged commit e95db0a into jupyterlab:master Dec 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.