Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wide prompts better #3431

Merged
merged 1 commit into from Dec 20, 2017
Merged

Handle wide prompts better #3431

merged 1 commit into from Dec 20, 2017

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 20, 2017

Previously, the prompt area was 100px wide. For small prompt numbers this seemed too generous, but for larger prompt numbers and larger font sizes, it was needed. This PR tries to improve the large prompt number and large font size handling while still narrowing the prompt area down to 90px through white space and text overflow handling.

This PR:

screen shot 2017-12-19 at 5 52 39 pm

screen shot 2017-12-19 at 5 53 07 pm

And with a big font size set in the browser:

screen shot 2017-12-19 at 5 53 39 pm

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 20, 2017

Thanks!

@blink1073 blink1073 merged commit 1babf5d into jupyterlab:master Dec 20, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 23, 2017
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants