Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typographical design for the beta #3445

Merged
merged 5 commits into from Dec 21, 2017
Merged

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 21, 2017

  • Better separation of ui, content and code typography.
  • Unified font scales for content and headings.
  • Careful consistency checks between markdown docuemnt and notebooks to amek sure that headings look similar - that cells don't add too much margin above and below.
  • Lots of small fixes to various things in rendered HTML.
  • fine tuning font colors.
  • Use system fonts if available (SF on Mac, Segoe on Win, Helvetica, Arial)

Current PR light:

screen shot 2017-12-20 at 7 00 48 pm

Current PR dark:

screen shot 2017-12-20 at 7 01 37 pm

Master:

screen shot 2017-12-20 at 7 11 53 pm

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 21, 2017

Fixes #2854

Loading

ellisonbg added 3 commits Dec 21, 2017
* Better separation of ui, content and code typography.
* Unified font scales for content and headings.
* Careful consistency checks between markdown docuemnt and notebooks to amek sure that headings look similar - that cells don't add too much margin above and below.
* Lots of small fixes to various things in rendered HTML.
* fine tuning font colors.
* Use system fonts if available (SF on Mac, Segoe on Win, Helvetica, Arial)
@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 21, 2017

Rebased and fixed the link colors - in the above screenshots the L/D theme link colors are reversed - we need light colored links in the dark theme and darker in the light theme for contrast purposes.

Loading

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 21, 2017

I am still loading Google Fonts, but we can do away with that if we decide on a good set of system based monospaced fonts. That can come in a separate PR - we should merge this ASAP to avoid lots of conflicts and rebasing...

Loading

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 21, 2017

Looks great, thanks!

Loading

@blink1073 blink1073 merged commit 97465a3 into jupyterlab:master Dec 21, 2017
2 checks passed
Loading
@blink1073 blink1073 mentioned this pull request Dec 21, 2017
@blink1073 blink1073 mentioned this pull request Dec 23, 2017
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants