Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Source Code Pro for monospace fonts #3457

Merged
merged 5 commits into from Dec 22, 2017

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 21, 2017

This ships the regular and bold weights of Source Code Pro, as .ttf files in the themes. I have created new styles/fonts directories in both themes for the files and have added the needed @font-face stuff in style/fonts/css. Not sure this is the best location for or method of loading the fonts, but it is a start.

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 21, 2017

This also completely removes the need to load any fonts from googleapi.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 584e755 into jupyterlab:master Dec 22, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 23, 2017
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants