Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the latest kernel banner in console on restart. #3663

Merged
merged 2 commits into from Mar 9, 2018

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 17, 2018

This PR refactors the banner code in the console to:

  1. Display the banner every time the kernel is connected (i.e., restarted, reconnected, started)
  2. keep track of the latest banner and keep it around when clearing the cells

There still is a possible race condition, where a kernel might be restarted and then quickly changed - the banner updated might be the wrong one. But this existed before, and I think this PR makes the usability better.

console

Fixes #3653.

Copy link
Member

@ian-r-rose ian-r-rose left a comment

Other than the one question, looks good to me.

let layout = this._content.layout as PanelLayout;
let banner = layout.widgets[0] as RawCell;
banner.model.value.text = info.banner;
this._banner.model.value.text = info.banner;
Copy link
Member

@ian-r-rose ian-r-rose Jan 17, 2018

Is it possible for this._banner to be null here?

}

private _banner: RawCell;
private _banner: RawCell = null;
Copy link
Member

@ian-r-rose ian-r-rose Jan 17, 2018

Related to above: can this be typed RawCell | null?

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Jan 17, 2018

Looks like a couple of the console tests need updating.

@jasongrout jasongrout added this to the Beta 2 milestone Jan 18, 2018
@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Mar 9, 2018

LGTM

@ian-r-rose ian-r-rose merged commit 99c56f6 into jupyterlab:master Mar 9, 2018
2 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants